[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest mem
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest memory |
Date: |
Wed, 13 Sep 2017 16:27:09 +0200 |
On Wed, 13 Sep 2017 16:20:35 +0200
Laurent Vivier <address@hidden> wrote:
> From: Cornelia Huck <address@hidden>
>
> It does not really make sense to dump memory that is not there.
>
> Moreover, that fixes a segmentation fault when calling dump-guest-memory
> with no filter for a machine with no memory defined.
>
> New behaviour is:
>
> (qemu) dump-guest-memory /dev/null
> dump: no guest memory to dump
> (qemu) dump-guest-memory /dev/null 0 4096
> dump: no guest memory to dump
>
> Signed-off-by: Cornelia Huck <address@hidden>
> Tested-by: Laurent Vivier <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> Reviewed-by: Greg Kurz <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> ---
> dump.c | 6 ++++++
> 1 file changed, 6 insertions(+)
You need to supply your s-o-b as well, no?