[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] question：a question about throttle and hot-unplug
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] question：a question about throttle and hot-unplug |
|
Date: |
Thu, 14 Sep 2017 13:34:54 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 14 Sep 2017 11:41:40 AM CEST, WangJie (Captain) wrote:
> the patch you commited:
> https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba
>
> remove blk_io_limits_disable from blk_remove_bs
>
> Then, if a disk which configured qos hot-unplug from VM, the backend
> of the disk reminds in throttle group.
>
> So when I hot-unplug and hot-plug a disk, and use the same throttle
> group name, will lead to qemu crash.
>
> and Eric committed a path as fallow fixed the bug on qemu-kvm 2.9.0-rc4:
> https://github.com/qemu/qemu/commit/1606e4cf8a976513ecac70ad6642a7ec45744cf5#diff-7cb66df56045598b75a219eebc27efb6
>
> Is what I said as below correct?
That sounds correct to me. Here's the original discussion for reference:
https://lists.gnu.org/archive/html/qemu-block/2017-04/msg00019.html
Berto