Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

[Peter Maydell]

On 14 September 2017 at 19:35, Richard Henderson
<address@hidden> wrote:
> If configured, prefer this over our rather dated copy of the
> GPLv2-only binutils.  This will be especially apparent with
> the proposed vector extensions to TCG, as disas/i386.c does
> not handle AVX.
>
> Signed-off-by: Richard Henderson <address@hidden>

> diff --git a/configure b/configure
> index fd7e3a5e81..a55a8eda8a 100755
> --- a/configure
> +++ b/configure
> @@ -366,6 +366,7 @@ opengl_dmabuf="no"
>  cpuid_h="no"
>  avx2_opt="no"
>  zlib="yes"
> +capstone=""
>  lzo=""
>  snappy=""
>  bzip2=""
> @@ -4381,6 +4382,18 @@ EOF
>  fi

We should have the usual --enable-capstone/--disable-capstone
option flags so distros can enforce that configure fails
if it can't find the dependency.

It's also tempting to suggesting making it into a submodule
so that we can dump the old binutils code entirely (or
just requiring capstone if you want the debug logging to
be any good).

thanks
-- PMM