[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative e
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code |
Date: |
Mon, 18 Sep 2017 15:03:07 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, 09/18 08:44, Kevin Wolf wrote:
> > > > > + self._qemu_full_args = (self._wrapper + [self._binary] +
> > > > > + self._base_args() + self._args)
> > > >
> > > > The parentheses seem superfluous. With those removed:
> > > >
> > > > Reviewed-by: Fam Zheng <address@hidden>
> > >
> > > Congratulations, with this advice you just killed all Python-based
> > > qemu-iotests and filled up my inbox with CI failure messages. :-)
> >
> > Oops. Why doesn't python understand such multi line expressions
> > impllied by "+" just like in "[,]"?
>
> To be honest, I didn't know that either until now. But apparently the
> different kinds of brackets (including those around function arguments)
> are the only things that allow multiline expressions in Python.
Yes, and now I read that PEP recommends using brackets for multilines compared
to backslashes. I was totally wrong with this advice.
Fam
- [Qemu-devel] [PATCH v8 01/13] qemu.py: fix is_running() return before first launch(), (continued)
[Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/01
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Fam Zheng, 2017/09/04
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error, Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup, Amador Pahim, 2017/09/01