[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: Assert that bkt->max is
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait() |
|
Date: |
Mon, 18 Sep 2017 11:58:56 +0200 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 13.09.2017 um 10:28 hat Alberto Garcia geschrieben:
> If bkt->max == 0 and bkt->burst_length > 1 then we could have a
> division by 0 in throttle_do_compute_wait(). That configuration is
> however not permitted and is already detected by throttle_is_valid(),
> but let's assert it in throttle_compute_wait() to make it explicit.
>
> Found by Coverity (CID: 1381016).
>
> Signed-off-by: Alberto Garcia <address@hidden>
Thanks, applied to the block branch.
Kevin