Re: [Qemu-devel] [PATCH v1 16/27] s390x/kvm: factor out SIGP code into sigp.c

[David Hildenbrand]

On 18.09.2017 19:25, Christian Borntraeger wrote:
> 
> 
> On 09/18/2017 06:00 PM, David Hildenbrand wrote:
>> We want to use the same code base for TCG, so let's cleanly factor it
>> out.
>>
>> The sigp mutex is currently not really needed, as everything is
>> protected by the iothread mutex. But this could change later, so leave
>> it in place and initialize it properly from common code.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>>  hw/s390x/s390-virtio-ccw.c |   3 +
>>  target/s390x/Makefile.objs |   1 +
>>  target/s390x/cpu.c         |   8 -
>>  target/s390x/cpu.h         |   6 +-
>>  target/s390x/internal.h    |   4 +
>>  target/s390x/kvm-stub.c    |   5 -
>>  target/s390x/kvm.c         | 349 +-----------------------------------------
>>  target/s390x/kvm_s390x.h   |   1 -
>>  target/s390x/sigp.c        | 366 
>> +++++++++++++++++++++++++++++++++++++++++++++
> 
> You should probably do something in MAINTAINERS for sigp.c,
> otherwise Conny and myself no longer maintain the sigp code.
> 

Good point, I'll add a patch. (copying the maintainers from kvm.c -  you
and Conny  :) )

-- 

Thanks,

David