[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair |
Date: |
Tue, 19 Sep 2017 10:10:28 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, 09/18 10:17, Eric Blake wrote:
> On 09/17/2017 09:43 PM, Fam Zheng wrote:
> > This will be used by setup test user ssh.
>
> Shouldn't the commit message have more details about WHY we are checking
> in a private key? The conversation last time included useful gems such as:
>
> Some guests require the key to exist prior to provisioning the guest,
> and reusing a pre-built key avoids consuming entropy every time the
> testsuite is run. Because the private key is well-known, care must be
> taken to use the key ONLY in situations that cannot be compromised by
> external network clients.
Yeah. Not everyone looks at the commit message, I'll add a tests/keys/README to
document that.
Fam
- [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux), Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 01/13] gitignore: Ignore vm test images, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 02/13] qemu.py: Add "wait()" method, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 03/13] scripts: Add archive-source.sh, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 05/13] tests: Add vm test lib, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 06/13] tests: Add ubuntu.i386 image, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 07/13] tests: Add FreeBSD image, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 08/13] tests: Add NetBSD image, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 09/13] tests: Add OpenBSD image, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 10/13] Makefile: Add rules to run vm tests, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 11/13] MAINTAINERS: Add tests/vm entry, Fam Zheng, 2017/09/17
- [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests, Fam Zheng, 2017/09/17