[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Dead code in cpu-models.h (was: block: Clean up some bad co
From: |
Thomas Huth |
Subject: |
[Qemu-devel] Dead code in cpu-models.h (was: block: Clean up some bad code in the vvfat driver) |
Date: |
Tue, 19 Sep 2017 10:14:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 19.09.2017 10:06, Paolo Bonzini wrote:
> On 13/09/2017 21:08, John Snow wrote:
[...]
>> Farewell, bitrot code.
>>
>> Reviewed-by: John Snow <address@hidden>
>>
>> Out of curiosity, I wonder ...
>>
>> address@hidden (foobar) ~/s/qemu> git grep '#if 0' | wc -l
>> 320
>
> $ git grep -c '#if 0' | sort -k2 --field-separator=: -n
> ...
> hw/net/eepro100.c:21
> target/ppc/cpu-models.h:76
>
> whoa :)
Igor recently already removed the dead definitions from cpu-models.c :
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=aef779605779579afbafff
I guess we could now remove the corresponding dead definitions from the
header, too...
Any volunteers?
Thomas
Re: [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver, Kevin Wolf, 2017/09/19