[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tests: Introduce generic device hot-plug/hot
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] tests: Introduce generic device hot-plug/hot-unplug functions |
|
Date: |
Tue, 19 Sep 2017 10:37:55 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/19/2017 10:22 AM, Thomas Huth wrote:
>>> + response2 = qmp("");
>>
>> Hmm, this new use of qmp("") means I get to rebase the efforts to remove
>> the empty qmp command usage from the testsuite efforts.
>
> Sorry about that :-/ I hope it's not too much of a hassle!
>
> Maybe we should finally also add some assert(strlen(fmt) > 0) to that
> function to avoid that the problem sneaks in again?
Yep, already proposed (and thus part of my ongoing rebase work):
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00599.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature