[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store rel
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store reload value |
|
Date: |
Wed, 20 Sep 2017 08:21:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/19/2017 07:15 PM, Richard Henderson wrote:
> On 09/19/2017 06:17 AM, Cédric Le Goater wrote:
>> + uint64_t reload;
>>
>> if (pclk) {
>> reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND,
>> s->pclk_freq);
>> } else {
>> - reload = s->regs[WDT_RELOAD_VALUE] * 1000;
>> + reload = s->regs[WDT_RELOAD_VALUE] * 1000UL;
>
> UL does not help ilp32 hosts. Need ULL or an explicit cast.
ok. I will send a fix.
Thanks,
C.