Re: [Qemu-devel] [PULL 00/32] Misc patches for 2017-09-22 (v2)

[Paolo Bonzini]

On 22/09/2017 20:09, Peter Maydell wrote:
> On 22 September 2017 at 16:04, Paolo Bonzini <address@hidden> wrote:
>> The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6:
>>
>>   Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into 
>> staging (2017-09-20 20:33:48 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 8acf7b48e0098198057db048340606c7fbfc6518:
>>
>>   chardev: remove context in chr_update_read_handler (2017-09-22 14:03:27 
>> +0200)
>>
>> v2 fixes some issues with the new qemu-pr-helper.  make install and systemd
>> socket activation were broken.  I have now backported it to the Fedora QEMU
>> packages to shake out any distro-level issues.
>>
>> ----------------------------------------------------------------
>> * Speed up AddressSpaceDispatch creation (Alexey)
>> * Fix kvm.c assert (David)
>> * Memory fixes and further speedup (me)
>> * Persistent reservation manager infrastructure (me)
>> * virtio-serial: add enable_backend callback (Pavel)
>> * chardev GMainContext fixes (Peter)
> 
> In today's episode of "compiler whinges" we have
> 
> /home/pm215/qemu/scsi/qemu-pr-helper.c: In function ‘main’:
> /home/pm215/qemu/scsi/qemu-pr-helper.c:912:5: error: comparison is
> always true due to limited range of data type [-Werror=type-limits]
>      while ((ch = getopt_long(argc, argv, sopt, lopt, &opt_ind)) != -1) {
>      ^
> 
> (reported by the gcc on my ppc64, s390x, aarch64, aarch32 setups).
> 
> This one's a genuine bug, I think: ch is a char, which is unsigned on
> these systems, and so the loop would never terminate.

Yes, it is a bug.  I copied the line from qemu-nbd, but qemu-nbd has
"int ch".

Paolo