[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass throu
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge |
Date: |
Sat, 23 Sep 2017 00:18:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/22/17 14:18, Mark Cave-Ayland wrote:
> Whilst the underlying PCI bridge implementation supports 32-bit PCI IO
> accesses, unfortunately they are truncated at the legacy 64K limit.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> hw/pci/pci_bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
> index 17feae5..a47d257 100644
> --- a/hw/pci/pci_bridge.c
> +++ b/hw/pci/pci_bridge.c
> @@ -379,7 +379,8 @@ void pci_bridge_initfn(PCIDevice *dev, const char
> *typename)
> sec_bus->address_space_mem = &br->address_space_mem;
> memory_region_init(&br->address_space_mem, OBJECT(br), "pci_bridge_pci",
> UINT64_MAX);
> sec_bus->address_space_io = &br->address_space_io;
> - memory_region_init(&br->address_space_io, OBJECT(br), "pci_bridge_io",
> 65536);
> + memory_region_init(&br->address_space_io, OBJECT(br), "pci_bridge_io",
> + UINT32_MAX);
> br->windows = pci_bridge_region_init(br);
> QLIST_INIT(&sec_bus->child);
> QLIST_INSERT_HEAD(&parent->child, sec_bus, sibling);
>
Based on the commit message, I assume this change is guest-visible. If
so, should it be made dependent on a compat property, so that it doesn't
cause problems with migration?
Thanks,
Laszlo
- [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Mark Cave-Ayland, 2017/09/22
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Richard Henderson, 2017/09/22
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Mark Cave-Ayland, 2017/09/23
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Marcel Apfelbaum, 2017/09/24
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Mark Cave-Ayland, 2017/09/24
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Dr. David Alan Gilbert, 2017/09/25
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Mark Cave-Ayland, 2017/09/28
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Laszlo Ersek, 2017/09/28
- Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge, Marcel Apfelbaum, 2017/09/28