[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions |
Date: |
Sat, 23 Sep 2017 15:28:49 +1000 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Wed, Sep 20, 2017 at 08:52:21PM +0200, Thomas Huth wrote:
> On 19.09.2017 23:36, John Snow wrote:
> > Remove *all* unused CPU definitions as indicated by compile-time
> > `#if 0` constructs.
> >
> > Signed-off-by: John Snow <address@hidden>
> > ---
> > target/ppc/cpu-models.h | 223
> > ------------------------------------------------
> > 1 file changed, 223 deletions(-)
> >
> > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
> > index b34b512..248f833 100644
> > --- a/target/ppc/cpu-models.h
> > +++ b/target/ppc/cpu-models.h
> [...]
> > @@ -234,24 +105,11 @@ enum {
> > CPU_POWERPC_440GXb = 0x51B21851,
> > CPU_POWERPC_440GXc = 0x51B21892,
> > CPU_POWERPC_440GXf = 0x51B21894,
> > -#if 0
> > - CPU_POWERPC_440S = xxx,
> > -#endif
> > CPU_POWERPC_440SP = 0x53221850,
> > CPU_POWERPC_440SP2 = 0x53221891,
> > CPU_POWERPC_440SPE = 0x53421890,
> > /* PowerPC 460 family */
> > -#if 0
> > - /* Generic PowerPC 464 */
> > -#define CPU_POWERPC_464 CPU_POWERPC_464H90
> > -#endif
> > /* PowerPC 464 microcontrolers */
> > -#if 0
> > - CPU_POWERPC_464H90 = xxx,
> > -#endif
> > -#if 0
> > - CPU_POWERPC_464H90FP = xxx,
> > -#endif
>
> I think you could also remove the "/* PowerPC 460 family */" and "/*
> PowerPC 464 microcontrolers */" lines now.
>
> Anyway:
>
> Reviewed-by: Thomas Huth <address@hidden>
Yes, I've made that extra change and applied.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature