[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 05/33] migration: better error handling with QE
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [RFC v2 05/33] migration: better error handling with QEMUFile |
Date: |
Tue, 26 Sep 2017 17:13:13 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Sep 26, 2017 at 09:53:44AM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (address@hidden) wrote:
> > On Thu, Sep 21, 2017 at 06:51:37PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > > > @@ -1969,6 +2002,10 @@ static int qemu_loadvm_state_main(QEMUFile *f,
> > > > MigrationIncomingState *mis)
> > > > goto out;
> > > > }
> > > > break;
> > > > + case QEMU_VM_EOF:
> > > > + /* This is the end of migration */
> > > > + goto out;
> > > > + break;
> > >
> > > You don't need the goto and the break (although it does no harm).
> >
> > I still need the goto to break the loop? (I think a single break will
> > only break the select, but not the loop)
> >
> > If I remove both "goto" and "break", it'll fall through to default, I
> > suppose that's not what we want?
>
> No, but if you have the 'goto' you don't need the 'break'.
I see. Let me remove the "break" after "goto" then. Thanks,
--
Peter Xu