[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy |
Date: |
Thu, 28 Sep 2017 10:59:35 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, Sep 28, 2017 at 10:59:58AM +0800, Peter Xu wrote:
> From: Stefan Hajnoczi <address@hidden>
>
> After iothread is enabled internally inside QEMU with GMainContext, we
> may encounter this warning when destroying the iothread:
>
> (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll:
> assertion '!SOURCE_DESTROYED (source)' failed
>
> The problem is that g_source_remove_poll() does not allow to remove one
> source from array if the source is detached from its owner
> context. (peterx: which IMHO does not make much sense)
>
> Fix it on QEMU side by avoid calling g_source_remove_poll() if we know
> the object is during destruction, and we won't leak anything after all
> since the array will be gone soon cleanly even with that fd.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> [peterx: write the commit message]
> Signed-off-by: Peter Xu <address@hidden>
> ---
> util/aio-posix.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
- [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal iothreads, Peter Xu, 2017/09/27
- [Qemu-devel] [PATCH v4 1/5] qom: provide root container for internal objs, Peter Xu, 2017/09/27
- [Qemu-devel] [PATCH v4 2/5] iothread: provide helpers for internal use, Peter Xu, 2017/09/27
- [Qemu-devel] [PATCH v4 3/5] iothread: export iothread_stop(), Peter Xu, 2017/09/27
- [Qemu-devel] [PATCH v4 4/5] iothread: delay the context release to finalize, Peter Xu, 2017/09/27
- [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy, Peter Xu, 2017/09/27
- Re: [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal iothreads, Stefan Hajnoczi, 2017/09/28