Re: [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full

[Paolo Bonzini]

On 22/09/2017 09:46, Fam Zheng wrote:
> Also avoid "set -e".
> 
> Signed-off-by: Fam Zheng <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

This broke docker-test-full with at least Fedora and CentOS 6 images.  I
wouldn't be surprised if some required packages do not even exist on
CentOS 6.  Should it be reverted?

Paolo

> ---
>  tests/docker/test-full | 82 
> ++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 76 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/docker/test-full b/tests/docker/test-full
> index 05f0d491d1..d71bf9d275 100755
> --- a/tests/docker/test-full
> +++ b/tests/docker/test-full
> @@ -1,8 +1,8 @@
> -#!/bin/bash -e
> +#!/bin/bash
>  #
> -# Compile all the targets.
> +# Compile all the targets with as many features enabled as possible
>  #
> -# Copyright (c) 2016 Red Hat Inc.
> +# Copyright 2016, 2017 Red Hat Inc.
>  #
>  # Authors:
>  #  Fam Zheng <address@hidden>
> @@ -13,7 +13,77 @@
>  
>  . common.rc
>  
> -cd "$BUILD_DIR"
> +cd "$BUILD_DIR" || exit 1
>  
> -build_qemu
> -make check $MAKEFLAGS
> +build_qemu \
> +    --enable-attr \
> +    --enable-bluez \
> +    --enable-brlapi \
> +    --enable-bsd-user \
> +    --enable-bzip2 \
> +    --enable-cap-ng \
> +    --enable-coroutine-pool \
> +    --enable-crypto-afalg \
> +    --enable-curl \
> +    --enable-curses \
> +    --enable-debug \
> +    --enable-debug-info \
> +    --enable-debug-tcg \
> +    --enable-docs \
> +    --enable-fdt \
> +    --enable-gcrypt \
> +    --enable-glusterfs \
> +    --enable-gnutls \
> +    --enable-gprof \
> +    --enable-gtk \
> +    --enable-guest-agent \
> +    --enable-jemalloc \
> +    --enable-kvm \
> +    --enable-libiscsi \
> +    --enable-libnfs \
> +    --enable-libssh2 \
> +    --enable-libusb \
> +    --enable-linux-aio \
> +    --enable-linux-user \
> +    --enable-live-block-migration \
> +    --enable-lzo \
> +    --enable-modules \
> +    --enable-numa \
> +    --enable-opengl \
> +    --enable-pie \
> +    --enable-profiler \
> +    --enable-qom-cast-debug \
> +    --enable-rbd \
> +    --enable-rdma \
> +    --enable-replication \
> +    --enable-sdl \
> +    --enable-seccomp \
> +    --enable-smartcard \
> +    --enable-snappy \
> +    --enable-spice \
> +    --enable-stack-protector \
> +    --enable-system \
> +    --enable-tcg \
> +    --enable-tcg-interpreter \
> +    --enable-tools \
> +    --enable-tpm \
> +    --enable-trace-backend=ftrace \
> +    --enable-usb-redir \
> +    --enable-user \
> +    --enable-vde \
> +    --enable-vhost-net \
> +    --enable-vhost-scsi \
> +    --enable-vhost-user \
> +    --enable-vhost-vsock \
> +    --enable-virtfs \
> +    --enable-vnc \
> +    --enable-vnc-jpeg \
> +    --enable-vnc-png \
> +    --enable-vnc-sasl \
> +    --enable-vte \
> +    --enable-werror \
> +    --enable-xen \
> +    --enable-xen-pci-passthrough \
> +    --enable-xen-pv-domain-build \
> +    --enable-xfsctl \
> +&& make check $MAKEFLAGS
>