[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 02/32] texi2pod: Support @verbatim environme
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 02/32] texi2pod: Support @verbatim environment |
Date: |
Fri, 6 Oct 2017 08:40:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/06/2017 12:24 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> On 10/02/2017 10:25 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>> ---
>>> scripts/texi2pod.pl | 11 +++++++++--
>>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>>> + and not (/address@hidden([a-z]+)/ and $1 eq $endw)) {
>>
>> You anchored to the beginning, but not the end, of the line; that means
>> you accept '@end verbatim garbage' as an end marker. Worth adding $?
>
> Cribbed from
>
> # End-block handler goes up here because it needs to operate even
> # if we are skipping.
> /address@hidden([a-z]+)/ and do {
> # Ignore @end foo, where foo is not an operation which may
> # cause us to skip, if we are presently skipping.
> my $ended = $1;
> next if $skipping && $ended !~
> /^(?:ifset|ifclear|ignore|menu|iftex|copying)$/;
>
> die "address@hidden $ended without address@hidden at line $.\n" unless
> defined $endw;
> die "address@hidden ended by address@hidden $ended at line $.\n" unless
> $ended eq $endw;
>
> $endw = pop @endwstack;
>
> I'd prefer to stick to this regexp.
Consistency makes sense.
>
> texi2pod.pl parses quite sloppily in general.
>
>> If that's the only change, I'm okay with adding:
>>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Does this apply to the unchanged patch, too?
Yes.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 00/32] Command line QAPIfication, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 24/32] qapi-options: Generate help string, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 18/32] docs/devel/qapi-code-gen.txt: Rewrite section on schema syntax, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 16/32] qapi: Factor out _make_implicit_wrapper_type(), Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 01/32] tests/qapi-schema: Improve coverage of '@', Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 04/32] qapi2texi: Fix for '@' not followed by \w character, Markus Armbruster, 2017/10/02
- [Qemu-devel] [RFC PATCH 09/32] qapi: check_type() parameter allow_optional is now unused, drop, Markus Armbruster, 2017/10/02