qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 24/30] s390x/tcg: implement STOP and RESET in


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 24/30] s390x/tcg: implement STOP and RESET interrupts for TCG
Date: Fri, 6 Oct 2017 09:59:09 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 09/28/2017 04:37 PM, David Hildenbrand wrote:
> Implement them like KVM implements/handles them. Both can only be
> triggered via SIGP instructions. RESET has (almos)the lowest priority if
> the CPU is running, and the highest if the CPU is STOPPED. This is handled
> in SIGP code already. On delivery, we only have to care about the
> "CPU running" scenario.
> 
> STOP is defined to be delivered after all other interrupts have been
> delivered. Therefore it has the actual lowest priority.
> 
> As both can wake up a CPU if sleeping, indicate them correctly to
> external code (e.g. cpu_has_work()).
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/cpu.h         |  4 ++++
>  target/s390x/excp_helper.c | 16 +++++++++++++++-
>  target/s390x/helper.c      |  1 +
>  target/s390x/internal.h    |  2 ++
>  target/s390x/interrupt.c   | 32 +++++++++++++++++++++++++++-----
>  target/s390x/sigp.c        |  2 ++
>  6 files changed, 51 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]