[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic |
Date: |
Tue, 10 Oct 2017 15:10:05 +0200 |
On Wed, 4 Oct 2017 17:41:44 +0200
Halil Pasic <address@hidden> wrote:
> Some of ioinst the handlers look very much the same: they basically
> delegate the work to the appropriate css function (doing some always the
> same stuff before and after the call to the appropriate css function).
> Let us create a template and get rid of some code.
>
> Signed-off-by: Halil Pasic <address@hidden>
> Suggested-by: Marc Hartmayer <address@hidden>
> ---
> target/s390x/ioinst.c | 59
> ++++++++++++---------------------------------------
> 1 file changed, 14 insertions(+), 45 deletions(-)
Staring at this patch, I'm not sure I like it, although I can't quite
put a finger on *what* I don't like... maybe the whole 'template'
approach.
- Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control, (continued)
[Qemu-devel] [PATCH v2 4/8] s390x: refactor error handling for XSCH handler, Halil Pasic, 2017/10/04
[Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair, Halil Pasic, 2017/10/04
[Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic, Halil Pasic, 2017/10/04
- Re: [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic,
Cornelia Huck <=
[Qemu-devel] [PATCH v2 6/8] s390x: refactor error handling for HSCH handler, Halil Pasic, 2017/10/04
[Qemu-devel] [PATCH v2 7/8] s390x: refactor error handling for MSCH handler, Halil Pasic, 2017/10/04