[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 6/7] io: cope with websock 'Connection' heade
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 6/7] io: cope with websock 'Connection' header having multiple values |
Date: |
Tue, 10 Oct 2017 12:42:55 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/10/2017 10:43 AM, Daniel P. Berrange wrote:
> The noVNC server sends a header "Connection: keep-alive, Upgrade" which
> fails our simple equality test. Split the header on ',', trim whitespace
> and then check for 'upgrade' token.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> io/channel-websock.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> @@ -440,7 +443,16 @@ static void
> qio_channel_websock_handshake_process(QIOChannelWebsock *ioc,
> goto bad_request;
> }
>
> - if (strcasecmp(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE) != 0)
> {
My first thought was whether you could just use strcasestr() instead of
strcasecmp(), rather than the malloc overhead of g_strsplit(). But that
would treat "noUpgradeGarbage" as success, making your approach a bit
stricter.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v1 1/7] io: monitor encoutput buffer size from websocket GSource, (continued)