Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

[Daniel P. Berrange]

On Wed, Oct 11, 2017 at 03:37:08PM +0100, Peter Maydell wrote:
> On 11 October 2017 at 09:35, Gerd Hoffmann <address@hidden> wrote:
> > The following changes since commit 567d0a19c7998fa366598b83d5a6e5f0759d3ea9:
> >
> >   Merge remote-tracking branch 
> > 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging 
> > (2017-10-10 13:25:46 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kraxel.org/qemu tags/ui-20171011-pull-request
> >
> > for you to fetch changes up to 92328b7104ffc825f10c33f3fd1866e940a523f7:
> >
> >   ui/gtk: Fix deprecation of vte_terminal_copy_clipboard (2017-10-11 
> > 10:03:31 +0200)
> >
> > ----------------------------------------------------------------
> > ui: use keycodemapdb for key code mappings, part one (v2)
> > ui: add qemu-keymap, update reverse keymaps (for qemu -k $map)
> > ui: fix for vte 0.50
> >
> > ----------------------------------------------------------------
> 
> Build failures:
> 
> NetBSD:
>   CC      ui/input-keymap.o
> /root/qemu/ui/input-keymap.c:8:44: fatal error:
> ui/input-keymap-linux-to-qcode.c: No such file or directory
>  #include "ui/input-keymap-linux-to-qcode.c"
>                                             ^
> 
> FreeBSD:
> 
> 
>   CC      ui/input-keymap.o
> /root/qemu/ui/input-keymap.c:8:10: fatal error:
> 'ui/input-keymap-linux-to-qcode.c' file not found
> #include "ui/input-keymap-linux-to-qcode.c"
>          ^

So something is still racing in these two.

I don't suppose you have the full log - interested if it
ever run the "GIT     ui/keycodemapdb dtc" rule and/or
re-ran configure earlier, or if this is literally all it
did ?

> 
> OpenBSD:
> 
> gmake: Entering directory '/home/qemu/build/all'
> /bin/sh: ./scripts/git-submodule.sh: No such file or directory
> gmake: Leaving directory '/home/qemu/build/all'
> gmake: Entering directory '/home/qemu/build/all'
>   GIT
> /bin/sh: ./scripts/git-submodule.sh: No such file or directory
> gmake: *** [Makefile:30: git-submodule-update] Error 1
> gmake: Leaving directory '/home/qemu/build/all'
> gmake: *** Waiting for unfinished jobs....
> gmake: Entering directory '/home/qemu/build/all'
> config-host.mak is out-of-date, running configure
> Install prefix    /usr/local
> [configure output snipped]
> gmake: Leaving directory '/home/qemu/build/all'
> 
> AArch32 Linux:
> 
> make: Entering directory '/home/peter.maydell/qemu/build/all-a32'
> config-host.mak is out-of-date, running configure
> Install prefix    /usr/local
> BIOS directory    /usr/local/share/qemu
> [...]
> VxHS block device no
>   GEN     config-host.h
>   GEN     module_block.h
>   GEN     ui/input-keymap-linux-to-qcode.c
>   GEN     ui/input-keymap-qcode-to-qnum.c
>   GEN     ui/input-keymap-qnum-to-qcode.c
>   GIT     ui/keycodemapdb dtc
>   GEN     trace/generated-tcg-tracers.h
>   GEN     trace/generated-helpers-wrappers.h
>   GEN     trace/generated-helpers.h
>   GEN     trace/generated-helpers.c
> Makefile:30: recipe for target 'git-submodule-update' failed

Damn, we should not throw away stderr in scripts/git-submodule.sh,
as its hides whatever error occurred for you here.

> make: *** [git-submodule-update] Error 128
> make: *** Waiting for unfinished jobs....
> make: Leaving directory '/home/peter.maydell/qemu/build/all-a32'
> 
> 
> The OpenBSD failure is because make now tries to run a
> script that uses #!/bin/bash, and this machine doesn't
> have bash installed. Do we really need to add bash to
> our build-dependencies? The script doesn't seem like it's
> doing anything that critically requires bash...

Yeah, that's easily replacable with /bin/sh


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|