Re: [Qemu-devel] [PATCH v4 0/9] Support the Capstone disassembler

[Peter Maydell]

On 28 September 2017 at 17:54, Richard Henderson
<address@hidden> wrote:
> Changes since v3:
>   * Adjust how the submodule is detected and invoked.
>     - This should fix the reported patchew failure,
>     - Fixes e.g. -m32 "cross" compilation, or similar
>       abi-changing option sets.
>
>
> r~
>
>
> Richard Henderson (9):
>   target/i386: Convert to disas_set_info hook
>   target/ppc: Convert to disas_set_info hook
>   disas: Remove unused flags arguments
>   disas: Support the Capstone disassembler library
>   i386: Support Capstone in disas_set_info
>   arm: Support Capstone in disas_set_info
>   ppc: Support Capstone in disas_set_info
>   disas: Remove monitor_disas_is_physical
>   disas: Add capstone as submodule

I think the "add as submodule" patch might want to be
revised in the light of the changes to handling of
submodules that the current UI pull request is making,
but are the first 8 patches here more or less ready to
go in?

My other issue with patch 9 is that I think all our
submodules should be for git repos hosted on
git.qemu.org (ie mirrored from somewhere else). So
we should get capstone mirrored first and then use it.

thanks
-- PMM