qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 9/9] disas: Add capstone as submodule


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v4 9/9] disas: Add capstone as submodule
Date: Fri, 13 Oct 2017 08:50:13 +0100
User-agent: mu4e 0.9.19; emacs 26.0.60

Richard Henderson <address@hidden> writes:

> On 10/02/2017 10:43 AM, Alex Bennée wrote:
>>> +    mkdir -p capstone
>>
>> Having a mkdir -p here seems a little out of place. Shouldn't the build
>> directory creation be handled by the make recipe?
>
> *shrug* We do this for the other directories at configure time.

fair enough.

Reviewed-by: Alex Bennée <address@hidden>

>
>
> r~


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]