Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

[Paolo Bonzini]

On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote:
>> @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg)
>>               * don't need to write at all so we don't cause
>>               * wear on the storage backing the region...
>>               */
>> -            *(volatile char *)addr = *addr;
>> +            *addr = *addr;
> I personally prefer the other form which is mostly self-explicit when
> reviewing this code.
> 
> Declaring addr non volatile and using volatile cast here:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> 

I agree with Philippe; in genereal, volatile is more of a property of
the access rather than the variable.

Paolo