Re: [Qemu-devel] [PATCH v3 0/2] Improve audio output quality

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 0/2] Improve audio output quality

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
093f5c6fbd audio/hda: create millisecond timers that handle IO
d65c59b7eb audio/paaudio: remove separate PA feeder threads

=== OUTPUT BEGIN ===
Checking PATCH 1/2: audio/paaudio: remove separate PA feeder threads...
ERROR: spaces required around that '|' (ctx:ExV)
#538: FILE: audio/paaudio.c:348:
+                |PA_STREAM_AUTO_TIMING_UPDATE, NULL, NULL);
                 ^

ERROR: spaces required around that '|' (ctx:ExV)
#549: FILE: audio/paaudio.c:353:
+                |PA_STREAM_AUTO_TIMING_UPDATE);
                 ^

ERROR: space prohibited between function name and open parenthesis '('
#621: FILE: audio/paaudio.c:417:
+    pa->ba.tlength = tlength * pa_frame_size (&pa->ss);

total: 3 errors, 0 warnings, 807 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: audio/hda: create millisecond timers that handle IO...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden