[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 23/42] amd_iommu: avoid needless includes in head
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v3 23/42] amd_iommu: avoid needless includes in header file |
Date: |
Tue, 17 Oct 2017 13:44:07 -0300 |
instead move them to the source file
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
---
hw/i386/amd_iommu.h | 5 -----
hw/i386/amd_iommu.c | 5 ++++-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
index d370ae3549..aeef802364 100644
--- a/hw/i386/amd_iommu.h
+++ b/hw/i386/amd_iommu.h
@@ -23,11 +23,6 @@
#include "hw/hw.h"
#include "hw/pci/pci.h"
-#include "hw/pci/msi.h"
-#include "hw/sysbus.h"
-#include "sysemu/dma.h"
-#include "hw/i386/pc.h"
-#include "hw/pci/pci_bus.h"
#include "hw/i386/x86-iommu.h"
/* Capability registers */
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index ad8155ca4c..eeaf0e0aa8 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -20,7 +20,10 @@
* Cache implementation inspired by hw/i386/intel_iommu.c
*/
#include "qemu/osdep.h"
-#include "hw/i386/amd_iommu.h"
+#include "hw/i386/pc.h"
+#include "hw/pci/msi.h"
+#include "hw/pci/pci_bus.h"
+#include "amd_iommu.h"
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "trace.h"
--
2.15.0.rc0
- [Qemu-devel] [PATCH v3 13/42] misc: remove duplicated includes, (continued)
- [Qemu-devel] [PATCH v3 13/42] misc: remove duplicated includes, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 14/42] ppc: remove duplicated includes, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 15/42] i386/hax: remove duplicated includes, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 16/42] i386/hax: remove duplicated include, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 17/42] nios2: remove duplicated includes (in code commented out), Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 18/42] misc: avoid "include/" in include path, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 21/42] hw/misc/pvpanic: remove unused #include, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 19/42] numa: remove unused #include, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 20/42] hw/input/vmmouse: remove unused #include, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 22/42] hw/ssi/aspeed_smc: remove unused #include, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 23/42] amd_iommu: avoid needless includes in header file,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 25/42] hw/ide: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 26/42] hw/ipmi: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 24/42] misc: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 28/42] hw/tpm: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 27/42] hw/i2c: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 29/42] hw/virtio-balloon: remove old i386 dependency, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 30/42] hw/unicore32: restrict hw addr defines to source file, Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 31/42] hw/timer/i8254: rename pit_init() -> i8254_pit_init(), Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 32/42] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init(), Philippe Mathieu-Daudé, 2017/10/17
- [Qemu-devel] [PATCH v3 33/42] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch, Philippe Mathieu-Daudé, 2017/10/17