[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimi
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimize |
|
Date: |
Tue, 17 Oct 2017 21:31:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/17/2017 03:16 PM, Emilio G. Cota wrote:
> On Mon, Oct 16, 2017 at 10:25:33 -0700, Richard Henderson wrote:
>> From: Richard Henderson <address@hidden>
>>
>> While we're touching many of the lines anyway, adjust the naming
>> of the functions to better distinguish when "TCGArg" vs "TCGTemp"
>> should be used.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
> (snip)
>> -static struct tcg_temp_info temps[TCG_MAX_TEMPS];
>> +static struct tcg_temp_info temps_[TCG_MAX_TEMPS];
>
> Is this rename really necessary?
It was a temp rename to ensure that all changes were made.
The variable disappears later.
r~
- [Qemu-devel] [PATCH v6 16/50] tcg: Push tcg_ctx into tcg_gen_callN, (continued)
- [Qemu-devel] [PATCH v6 16/50] tcg: Push tcg_ctx into tcg_gen_callN, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 18/50] tcg: Reserve temporary index 0, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 17/50] tcg: Introduce index_arg, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 19/50] target/alpha: Avoid translate_init unless tcg_enabled, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 14/50] tcg: Use per-temp state data in optimize, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 21/50] tcg: Use pointers in TCGOp->args, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 23/50] hack dump tb->flags and tb->cflags, Richard Henderson, 2017/10/16
- [Qemu-devel] [PATCH v6 24/50] tcg: Add CPUState step_next_tb, Richard Henderson, 2017/10/16