Re: [Qemu-devel] [PATCH] scripts: don't throw away stderr when checking out git submodules

[Peter Maydell]

On 20 October 2017 at 14:07, Daniel P. Berrange <address@hidden> wrote:
> The stderr from git is important if git fails to checkout modules
> due to network problems, or other unexpected errors.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  scripts/git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
> index d8fbc7e47e..08932a35f0 100755
> --- a/scripts/git-submodule.sh
> +++ b/scripts/git-submodule.sh
> @@ -32,7 +32,7 @@ status)
>      exit $?
>      ;;
>  update)
> -    git submodule update --init $modules 1>/dev/null 2>&1
> +    git submodule update --init $modules 1>/dev/null
>      git submodule status $modules > "${substat}"
>      ;;

Is there a reason why we say "1>/dev/null" rather than just ">/dev/null" ?

thanks
-- PMM