Re: [Qemu-devel] [PATCH v4 3/7] migration: Wait for semaphore before completing migration

[Juan Quintela]

"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Wait for a semaphore before completing the migration,
> if the previously added capability was enabled.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>


> +    while (qemu_sem_timedwait(&s->pause_sem, 1) == 0) {

wait

> +        /* This block intentionally left blank */
> +    }
> +

> +    qemu_sem_wait(&s->pause_sem);


wait

and no posts on the whole patchset.

I agree that we only wait if we enable the feature, but still O:-)