Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0

[Gabriel Costa]

Hi Philippe,

Thanks for all your comments!
I will put all this corrections for the next patch, also I removed the
FlexTimer, it is not necessary to do this basic emulation.

Thanks,

Gabriel


On Fri, Oct 20, 2017 at 6:25 PM, Philippe Mathieu-Daudé <address@hidden>
wrote:

> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_SPI, 0x4002C000,
> > +            qdev_get_gpio_in(nvic, 31)); *SPI0*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_SPI, 0x4002D000,
> > +            qdev_get_gpio_in(nvic, 33)); *SPI1*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_ADC, 0x4003B000,
> > +            qdev_get_gpio_in(nvic, 31)); *ADC0*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_DAC, 0x4002F000,
> > +            qdev_get_gpio_in(nvic, 33)); *DAC0*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_I2C, 0x40066000,
> > +            qdev_get_gpio_in(nvic, 31)); *I2C0*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_I2C, 0x40067000,
> > +            qdev_get_gpio_in(nvic, 33)); *I2C1*/
> > +
> > +//    sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x4006A000,
> > +//            qdev_get_gpio_in(nvic, 31)); /*UART0*/
> > +    kinetis_k64_uart_create(0x4006A000, qdev_get_gpio_in(nvic, 31),
> > +            serial_hds[0]);
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x4006B000,
> > +            qdev_get_gpio_in(nvic, 33)); *UART1*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x4006C000,
> > +            qdev_get_gpio_in(nvic, 35)); *UART2*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x4006D000,
> > +            qdev_get_gpio_in(nvic, 37)); *UART3*/
> > +
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_SPI, 0x400AC000,
> > +            qdev_get_gpio_in(nvic, 65)); *SPI2*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_ADC, 0x400BB000,
> > +            qdev_get_gpio_in(nvic, 73)); *ADC1*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_I2C, 0x400E6000,
> > +            qdev_get_gpio_in(nvic, 74)); *I2C2*/
> > +
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x400EA000,
> > +            qdev_get_gpio_in(nvic, 66)); *UART4*/
> > +/*    dev = sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x400EB000,
> > +            qdev_get_gpio_in(nvic, 68)); *UART5*/
>
> Just create those with create_unimplemented_device() instead...
>
> > +
> > +    create_unimplemented_device("peripheral_bridge_0",  0x40000000,
> 0x1000);
> > +    create_unimplemented_device("Crossbar_Switch",      0x40004000,
> 0x1000);
> > +    create_unimplemented_device("DMA_Controller",       0x40008000,
> 0x1000);
> > +    create_unimplemented_device("DMA_Controller_t",     0x40009000,
> 0x1000);
> > +    create_unimplemented_device("FlexBus",              0x4000C000,
> 0x1000);
> > +    create_unimplemented_device("MPU",                  0x4000D000,
> 0x1000);
> > +    create_unimplemented_device("Flash_mem_ctrl",       0x4001F000,
> 0x1000);
> > +    create_unimplemented_device("Flash_mem",            0x40020000,
> 0x1000);
> > +    create_unimplemented_device("DMA_ch_multiplexer",   0x40021000,
> 0x1000);
> > +}
>