[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule |
Date: |
Tue, 24 Oct 2017 21:40:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/24/2017 06:45 PM, Philippe Mathieu-Daudé wrote:
> Hi Richard,
>
> On 10/21/2017 09:46 PM, Richard Henderson wrote:
>> Do not require the submodule, but use it if present. Allow the
>> command-line to override system or git submodule either way.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> Makefile | 13 +++++++++++++
>> .gitmodules | 3 +++
>> capstone | 1 +
>> configure | 60
>> +++++++++++++++++++++++++++++++++++++++++++++++++-----------
>> 4 files changed, 66 insertions(+), 11 deletions(-)
>> create mode 160000 capstone
>>
>> diff --git a/Makefile b/Makefile
>> index 9372742f86..beecc85bee 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -383,6 +383,19 @@ subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests
>> dtc/%: .git-submodule-status
>> mkdir -p $@
>>
>> +# Overriding CFLAGS causes us to lose defines added in the sub-makefile.
>> +# Not overriding CFLAGS leads to mis-matches between compilation modes.
>> +# Therefore we replicate some of the logic in the sub-makefile.
>
> I'm having plenty of "missing-prototypes" warnings:
Yes, we use lots of -Wfoo that upstream Capstone does not. I do strip -Werror,
so at least it builds. Are you suggesting that I drop most of our extra -Wfoo?
I suppose that's reasonable. We don't want our developers worrying about
warnings coming from upstream code. If in fact you believe that most of our
developers won't just install libcapstone-dev and be done?
r~
- Re: [Qemu-devel] [PATCH v7 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY, (continued)
- [Qemu-devel] [PATCH v7 05/11] disas: Remove unused flags arguments, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 06/11] disas: Support the Capstone disassembler library, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 07/11] i386: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 08/11] arm: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 09/11] ppc: Support Capstone in disas_set_info, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 10/11] disas: Remove monitor_disas_is_physical, Richard Henderson, 2017/10/21
- [Qemu-devel] [PATCH v7 11/11] disas: Add capstone as submodule, Richard Henderson, 2017/10/21
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler, no-reply, 2017/10/21
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler, no-reply, 2017/10/21
- Re: [Qemu-devel] [PATCH v7 00/11] Support the Capstone disassembler, no-reply, 2017/10/21