[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL* |
Date: |
Tue, 24 Oct 2017 21:56:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/24/2017 05:11 AM, Philippe Mathieu-Daudé wrote:
>> /* If no temporary was used, be careful not to alias t1 and t0. */
>> - t0 = TCGV_EQUAL(t1, cpu_cc_src) ? cpu_tmp0 : reg;
>> + t0 = t1 == cpu_cc_src ? cpu_tmp0 : reg;
> As I noticed in a previous patch, this expression is a bit easier/faster
> to read/review with parenthesis are used:
>
> t0 = (t1 == cpu_cc_src ? cpu_tmp0 : reg);
You're right. And I normally write it this way myself, even though operator
precedence does not require it.
But this is a case of search-and-replace, and I didn't retouch such things.
r~
- Re: [Qemu-devel] [PATCH v7 21/52] tcg: Use offsets not indices for TCGv_*, (continued)
- [Qemu-devel] [PATCH v7 20/52] qom: Introduce CPUClass.tcg_initialize, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 23/52] tcg: define CF_PARALLEL and use it for TB hashing along with CF_COUNT_MASK, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 25/52] tcg: Include CF_COUNT_MASK in CF_HASH_MASK, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 19/52] tcg: Remove TCGV_EQUAL*, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 24/52] tcg: Add CPUState cflags_next_tb, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 29/52] target/i386: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 28/52] target/hppa: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 27/52] target/arm: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 30/52] target/m68k: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 26/52] tcg: convert tb->cflags reads to tb_cflags(tb), Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 32/52] target/sh4: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 31/52] target/s390x: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20
- [Qemu-devel] [PATCH v7 33/52] target/sparc: check CF_PARALLEL instead of parallel_cpus, Richard Henderson, 2017/10/20