Re: [Qemu-devel] [PATCH v4 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

[Alistair Francis]

On Fri, Oct 27, 2017 at 7:56 AM, Francisco Iglesias
<address@hidden> wrote:
> Add support for continuous read out of the RDSR and READ_FSR status
> registers until the chip select is deasserted. This feature is supported
> by amongst others 1 or more flashtypes manufactured by Numonyx (Micron),
> Windbond, SST, Gigadevice, Eon and Macronix.
>
> Signed-off-by: Francisco Iglesias <address@hidden>
> Acked-by: Marcin Krzemiński <address@hidden>

Acked-by: Alistair Francis <address@hidden>

Alistair

> ---
>  hw/block/m25p80.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index a2438b9..2971519 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -423,6 +423,7 @@ typedef struct Flash {
>      uint8_t data[M25P80_INTERNAL_DATA_BUFFER_SZ];
>      uint32_t len;
>      uint32_t pos;
> +    bool data_read_loop;
>      uint8_t needed_bytes;
>      uint8_t cmd_in_progress;
>      uint32_t cur_addr;
> @@ -983,6 +984,7 @@ static void decode_new_cmd(Flash *s, uint32_t value)
>          }
>          s->pos = 0;
>          s->len = 1;
> +        s->data_read_loop = true;
>          s->state = STATE_READING_DATA;
>          break;
>
> @@ -993,6 +995,7 @@ static void decode_new_cmd(Flash *s, uint32_t value)
>          }
>          s->pos = 0;
>          s->len = 1;
> +        s->data_read_loop = true;
>          s->state = STATE_READING_DATA;
>          break;
>
> @@ -1133,6 +1136,7 @@ static int m25p80_cs(SSISlave *ss, bool select)
>          s->pos = 0;
>          s->state = STATE_IDLE;
>          flash_sync_dirty(s, -1);
> +        s->data_read_loop = false;
>      }
>
>      DB_PRINT_L(0, "%sselect\n", select ? "de" : "");
> @@ -1198,7 +1202,9 @@ static uint32_t m25p80_transfer8(SSISlave *ss, uint32_t 
> tx)
>          s->pos++;
>          if (s->pos == s->len) {
>              s->pos = 0;
> -            s->state = STATE_IDLE;
> +            if (!s->data_read_loop) {
> +                s->state = STATE_IDLE;
> +            }
>          }
>          break;
>
> --
> 2.9.3
>
>