[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 00/12] nbd minimal structured read
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v6 00/12] nbd minimal structured read |
Date: |
Fri, 27 Oct 2017 12:40:25 +0200 |
I've incorporated a few more tweaks since v5, addressing the various
bugs I pointed out there:
https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg04817.html
- make sure iotests pass
- split a large patch
- consistently use absolute offsets
- clean up awkward logic in handling option requests
I plan to send a pull request before Tuesday's freeze deadline; with a
plan to do lots of interoperability testing (including validation of
behavior against a server that sends more than one chunk for a read),
and with any resulting bug fixes trying to land as soon as possible
during the freeze.
I'm also a bit disappointed that iotest 83 is more verbose. I'll post a
follow RFC that undoes the verbosity regression, as evidence that we
should probably be tracing things instead; such a cleanup would count
as a bug fix, even if my pull request includes this series as-is.
001/12:[----] [--] 'nbd: Include error names in trace messages'
002/12:[----] [--] 'nbd: Move nbd_errno_to_system_errno() to public header'
003/12:[----] [--] 'nbd: Expose constants and structs for structured read'
004/12:[----] [--] 'nbd/server: Report error for write to read-only export'
005/12:[down] 'nbd/server: Simplify nbd_negotiate_options loop'
006/12:[0066] [FC] 'nbd/server: Refactor zero-length option check'
007/12:[0007] [FC] 'nbd: Minimal structured read for server'
008/12:[----] [--] 'nbd/server: Include human-readable message in structured
errors'
009/12:[0004] [FC] 'nbd/client: refactor nbd_receive_starttls'
010/12:[----] [--] 'nbd/client: prepare nbd_receive_reply for structured reply'
011/12:[----] [--] 'nbd: Move nbd_read() to common header'
012/12:[0055] [FC] 'nbd: Minimal structured read for client'
Eric Blake (8):
nbd: Include error names in trace messages
nbd: Move nbd_errno_to_system_errno() to public header
nbd: Expose constants and structs for structured read
nbd/server: Report error for write to read-only export
nbd/server: Simplify nbd_negotiate_options loop
nbd/server: Refactor zero-length option check
nbd/server: Include human-readable message in structured errors
nbd: Move nbd_read() to common header
Vladimir Sementsov-Ogievskiy (4):
nbd: Minimal structured read for server
nbd/client: refactor nbd_receive_starttls
nbd/client: prepare nbd_receive_reply for structured reply
nbd: Minimal structured read for client
block/nbd-client.h | 1 +
include/block/nbd.h | 106 +++++++++-
nbd/nbd-internal.h | 23 +--
block/nbd-client.c | 492 ++++++++++++++++++++++++++++++++++++++++++---
nbd/client.c | 217 +++++++++++++-------
nbd/common.c | 84 ++++++++
nbd/server.c | 209 ++++++++++++++-----
nbd/trace-events | 15 +-
tests/qemu-iotests/083.out | 15 ++
9 files changed, 968 insertions(+), 194 deletions(-)
--
2.13.6
- [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read,
Eric Blake <=
- [Qemu-devel] [PATCH v6 01/12] nbd: Include error names in trace messages, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 02/12] nbd: Move nbd_errno_to_system_errno() to public header, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 03/12] nbd: Expose constants and structs for structured read, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 05/12] nbd/server: Simplify nbd_negotiate_options loop, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 04/12] nbd/server: Report error for write to read-only export, Eric Blake, 2017/10/27
- [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check, Eric Blake, 2017/10/27