[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lin
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines |
Date: |
Fri, 27 Oct 2017 16:46:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 10/27/2017 04:30 PM, Collin L. Walling wrote:
> The sclp console in the s390 bios writes raw data,
> leading console emulators (such as virsh console) to
> treat a new line ('\n') as just a new line instead
> of as a Unix line feed. Because of this, output
> appears in a "stair case" pattern.
>
> Let's print \r\n on every occurrence of a new line
> in the string passed to write to amend this issue.
>
> This is in sync with the guest Linux code in
> drivers/s390/char/sclp_vt220.c which also does a line feed
> conversion in the console part of the driver.
>
> This fixes the s390-ccw and s390-netboot output like
> $ virsh start test --console
> Domain test started
> Connected to domain test
> Escape character is ^]
> Network boot starting...
> Using MAC address: 02:01:02:03:04:05
> Requesting
> information via DHCP: 010
>
> Signed-off-by: Collin L. Walling <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
FWIW, please remove my signed-off-by when resending.