[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than th
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate() |
Date: |
Fri, 3 Nov 2017 15:10:21 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote:
> On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote:
> > On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote:
> > > ioh3420_interrupts_init() pass error message to local_err, then
> > > propagate it to errp by error_propagate(), which is not necessary.
> > > So eliminate it and pass errp directly instead of local_err.
> > >
> > > Cc: "Michael S. Tsirkin" <address@hidden>
> > > Cc: Marcel Apfelbaum <address@hidden>
> > > Signed-off-by: Mao Zhongyi <address@hidden>
> > > Reviewed-by: Eric Blake <address@hidden>
> > > Reviewed-by: Marcel Apfelbaum <address@hidden>
> > > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > > ---
> > > v4:
> > > it not apply clearly on HEAD, so rebase it and modify the commit
> > > message.
> > > ---
> > >
> > > hw/pci-bridge/ioh3420.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Hi,
>
> Long time no news. Ping...
This patch should go through Michael Tsirkin's tree.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate(),
Stefan Hajnoczi <=