[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule upd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule updates to be disabled |
Date: |
Fri, 3 Nov 2017 13:35:11 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/03/2017 10:33 AM, Daniel P. Berrange wrote:
> Some people building QEMU use VPATH builds where the source directory is on a
> read-only volume. In such a case 'scripts/git-submodules.sh update' will
> always
> fail and users are required to run it manually themselves on their original
> writable source directory.
>
> While this is already supported, it is nice to give users a command line flag
> to configure to permanently disable automatic submodule updates, as it means
> they won't get hard to diagnose failures from git-submodules.sh at an
> arbitrary
> later date.
>
> This patch thus introduces a flag '--disable-git-update' which will prevent
> 'make' from ever running 'scripts/git-submodules.sh update'. It will still run
> the 'status' command to determine if a submodule update is needed, but when it
> does this it'll simply stop and print a message instructing the developer what
> todo. eg
>
> $ ./configure --target-list=x86_64-softmmu --disable-git-update
> ...snip...
>
> $ make
> GEN config-host.h
> GEN trace/generated-tcg-tracers.h
> GEN trace/generated-helpers-wrappers.h
> GEN trace/generated-helpers.h
> GEN trace/generated-helpers.c
> GEN module_block.h
>
> GIT submodule checkout is out of date. Please run
> scripts/git-submodule.sh update ui/keycodemapdb
> from the source directory checkout /home/berrange/src/virt/qemu
>
> make: *** [Makefile:31: git-submodule-update] Error 1
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> Makefile | 11 +++++++++++
> configure | 7 +++++++
> scripts/git-submodule.sh | 9 +++++++++
> 3 files changed, 27 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling, Daniel P. Berrange, 2017/11/03
- [Qemu-devel] [PATCH v3 1/5] build: allow setting a custom GIT binary for transparent proxying, Daniel P. Berrange, 2017/11/03
- [Qemu-devel] [PATCH v3 2/5] build: don't create temporary files in source dir, Daniel P. Berrange, 2017/11/03
- [Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule updates to be disabled, Daniel P. Berrange, 2017/11/03
- Re: [Qemu-devel] [PATCH v3 3/5] build: allow automatic git submodule updates to be disabled,
Eric Blake <=
- [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Daniel P. Berrange, 2017/11/03
- Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Eric Blake, 2017/11/03
- Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Alexey Kardashevskiy, 2017/11/06
- Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Alexey Kardashevskiy, 2017/11/07
- Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Alexey Kardashevskiy, 2017/11/08
- Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list, Daniel P. Berrange, 2017/11/08