[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/16] target/xtensa: implement const16
From: |
Max Filippov |
Subject: |
Re: [Qemu-devel] [PATCH 15/16] target/xtensa: implement const16 |
Date: |
Sun, 5 Nov 2017 16:03:10 -0800 |
On Sun, Nov 5, 2017 at 3:43 PM, Max Filippov <address@hidden> wrote:
>> however I think this can be simplified in 1 instr on target supporting
>> deposit32:
>>
>> tcg_gen_deposit_i32(cpu_R[arg[0]], cpu_R[arg[1]], cpu_R[arg[0]], 16, 16)
>
> arg[1] is an immediate argument, not a register index, so probably not.
Oh, I've got it, replace cpu_R[arg[1]] with a temporary:
TCGv_i32 c = tcg_const_i32(arg[1]);
tcg_gen_deposit_i32(cpu_R[arg[0]], c, cpu_R[arg[0]], 16, 16);
tcg_temp_free(c);
--
Thanks.
-- Max
- [Qemu-devel] [PATCH 03/16] target/xtensa: extract core opcode translators, (continued)
- [Qemu-devel] [PATCH 03/16] target/xtensa: extract core opcode translators, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 10/16] target/xtensa: tests: fix memctl SR test, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 11/16] target/xtensa: drop DisasContext::litbase, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 13/16] target/xtensa: implement salt/saltu, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 09/16] target/xtensa: use libisa for instruction decoding, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 12/16] target/xtensa: add internal/noop SRs and opcodes, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 14/16] target/xtensa: implement GPIO32, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 15/16] target/xtensa: implement const16, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 16/16] target/xtensa: implement disassembler, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 08/16] target/xtensa: switch fsf to libisa, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 06/16] target/xtensa: switch dc232b to libisa, Max Filippov, 2017/11/03
- [Qemu-devel] [PATCH 07/16] target/xtensa: switch dc233c to libisa, Max Filippov, 2017/11/03
- Re: [Qemu-devel] [PATCH 00/16] target/xtensa: switch to libisa, no-reply, 2017/11/05
- Re: [Qemu-devel] [PATCH 00/16] target/xtensa: switch to libisa, no-reply, 2017/11/06