[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 09/28] tpm-passthrough: don't save guessed cancel
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v2 09/28] tpm-passthrough: don't save guessed cancel_path in options |
Date: |
Mon, 6 Nov 2017 19:39:06 +0100 |
The value is later unneeded, and may leak if the free visitor doesn't
consider it since has_cancel_path is false. And for consistency with
"path" it shouldn't be returned in get_tpm_options().
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
---
hw/tpm/tpm_passthrough.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c
index 8c002e4da6..048edb1a1a 100644
--- a/hw/tpm/tpm_passthrough.c
+++ b/hw/tpm/tpm_passthrough.c
@@ -226,9 +226,7 @@ static int
tpm_passthrough_open_sysfs_cancel(TPMPassthruState *tpm_pt)
if (snprintf(path, sizeof(path), "/sys/class/misc/%s/device/cancel",
dev) < sizeof(path)) {
fd = qemu_open(path, O_WRONLY);
- if (fd >= 0) {
- tpm_pt->options->cancel_path = g_strdup(path);
- } else {
+ if (fd < 0) {
error_report("tpm_passthrough: Could not open TPM cancel "
"path %s : %s", path, strerror(errno));
}
--
2.15.0.rc0.40.gaefcc5f6f
- [Qemu-devel] [PATCH v2 02/28] tpm: move TpmIf in include/sysemu/tpm.h, (continued)
- [Qemu-devel] [PATCH v2 02/28] tpm: move TpmIf in include/sysemu/tpm.h, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 03/28] tpm-backend: store TPMIf interface, improve backend_init(), Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 04/28] tpm-tis: no longer expose TPMState, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 06/28] tpm-be: report error instead of front-end, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 05/28] tpm-be: call request_completed() out of thread, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 07/28] tpm-be: ask model to the TPM interface, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 08/28] tpm: remove unused opened code, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 09/28] tpm-passthrough: don't save guessed cancel_path in options,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v2 11/28] tpm-passthrough: pass TPMPassthruState to handle_device_opts, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 12/28] tpm-backend: move set 'id' to common code, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 10/28] tpm-be: update optional function pointers, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 13/28] tpm-passthrough: make it safer to destroy after creation, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 14/28] tpm-passthrough: simplify create(), Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 15/28] tpm-passthrough: workaround a possible race, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 16/28] tpm-tis: simplify header inclusion, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 17/28] tpm: rename qemu_find_tpm() -> qemu_find_tpm_be(), Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 18/28] tpm: lookup the the TPM interface instead of TIS device, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 19/28] tpm: add TPM interface to lookup TPM version, Marc-André Lureau, 2017/11/06