[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper fo
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper for QMP |
Date: |
Tue, 7 Nov 2017 14:58:36 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, 11/06 17:46, Peter Xu wrote:
> In monitor_qmp_read(), we have the hack to temporarily replace the
> cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher
> routine since the Monitor pointer can be passed in to that using the new
> JSON Parser opaque field now.
>
> This does not make much sense as a single patch. However, this will be
> a big step for the next patch, when the QMP dispatcher routine will be
> split from the QMP parser.
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [RFC v3 02/27] qobject: introduce qstring_get_try_str(), (continued)
- [Qemu-devel] [RFC v3 03/27] qobject: introduce qobject_get_try_str(), Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 04/27] qobject: let object_property_get_str() use new API, Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 05/27] monitor: move skip_flush into monitor_data_init, Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 06/27] qjson: add "opaque" field to JSONMessageParser, Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper for QMP, Peter Xu, 2017/11/06
- Re: [Qemu-devel] [RFC v3 07/27] monitor: move the cur_mon hack deeper for QMP,
Fam Zheng <=
- [Qemu-devel] [RFC v3 08/27] monitor: unify global init, Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 09/27] monitor: let mon_list be tail queue, Peter Xu, 2017/11/06
- [Qemu-devel] [RFC v3 10/27] monitor: create monitor dedicate iothread, Peter Xu, 2017/11/06
[Qemu-devel] [RFC v3 11/27] monitor: allow to use IO thread for parsing, Peter Xu, 2017/11/06