Re: [Qemu-devel] [PATCH v4 40/45] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report()

[Richard W.M. Jones]

On Wed, Nov 08, 2017 at 08:43:45PM -0300, Philippe Mathieu-Daudé wrote:
> > @@ -126,7 +125,7 @@ void watchdog_perform_action(void)
> >  
> >      case WATCHDOG_ACTION_DEBUG:
> >          qapi_event_send_watchdog(WATCHDOG_ACTION_DEBUG, &error_abort);
> > -        fprintf(stderr, "watchdog: timer fired\n");
> > +        error_report("watchdog: timer fired");
> 
> I don't think this is an error and would rather use info_report() here.
> 
> Richard what do you think?

Yes, this is not an error.  It's an informational message.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top