[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky |
Date: |
Thu, 9 Nov 2017 08:03:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/08/2017 07:38 PM, Max Reitz wrote:
> This patch fixes two race conditions in 030:
>
> 1. The first is in TestENSPC.test_enospc(). After resuming the job,
s/ENSPC/ENOSPC/
> querying it to confirm it is no longer paused may fail because in the
> meantime it might have completed already. The same was fixed in
> TestEIO.test_ignore() already (in commit
> 2c3b44da07d341557a8203cc509ea07fe3605e11).
>
> 2. The second is in TestSetSpeed.test_set_speed_invalid(): Here, a
> stream job is started on a drive without any break points, with a
> block-job-set-speed invoked subsequently. However, without any break
> points, the job might have completed in the meantime (on tmpfs at
> least); or it might complete before cancel_and_wait() which expects
> the job to still exist. This can be fixed like everywhere else by
> pausing the drive (installing break points) before starting the job
> and letting cancel_and_wait() resume it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/030 | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] iotests: Make some tests less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky, Max Reitz, 2017/11/08
- Re: [Qemu-devel] [PATCH 1/5] iotests: Make 030 less flaky,
Eric Blake <=
- [Qemu-devel] [PATCH 2/5] iotests: Add missing 'blkdebug::' in 040, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 3/5] iotests: Make 055 less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 4/5] iotests: Make 083 less flaky, Max Reitz, 2017/11/08
- [Qemu-devel] [PATCH 5/5] iotests: Make 136 less flaky, Max Reitz, 2017/11/08
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] iotests: Make some tests less flaky, Stefan Hajnoczi, 2017/11/09