[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] iotests: Make 083 less flaky
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] iotests: Make 083 less flaky |
Date: |
Thu, 9 Nov 2017 14:58:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/09/2017 02:30 PM, Max Reitz wrote:
> 083 has (at least) two issues:
>
> 1. By launching the nbd-fault-injector in background, it may not be
> scheduled until the first grep on its output file is executed.
> However, until then, that file may not have been created yet -- so it
> either does not exist yet (thus making the grep emit an error), or it
> does exist but contains stale data (thus making the rest of the test
> case work connect to a wrong address).
> Fix this by explicitly overwriting the output file before executing
> nbd-fault-injector.
>
> 2. The nbd-fault-injector prints things other than "Listening on...".
> It also prints a "Closing connection" message from time to time. We
> currently invoke sed on the whole file in the hope of it only
> containing the "Listening on..." line yet. That hope is sometimes
> shattered by the brutal reality of race conditions, so invoke grep
> before sed.
Comment is now stale; s/invoke grep before sed/make the sed script more
robust/
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v2 5/5] iotests: Make 136 less flaky, Max Reitz, 2017/11/09
Re: [Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky, Max Reitz, 2017/11/09