Re: [Qemu-devel] [PATCH] SDL2 various fixes

[Philippe Mathieu-Daudé]

Hi Jindrich,

On 11/12/2017 07:42 AM, Jindrich Makovicka wrote:
> Hi,
> 
> here is a revised patchset:

Please increment the patchset version when you respin (this is v2).

> 
> - sdl2: Do not hide the cursor on auxilliary windows 
>     split into two
> 
> - sdl2: Only accept the hotkeys on the main window 
>     reworked, also with a more descriptive commit message
> 
> - sdl2: Do not quit the emulator when an auxilliary window is closed
>     added missing scon->hidden update
> 
> - sdl2: Fix broken display updating after the window is hidden
>     added scon->hidden update instead + the SHOWN part changed
>     the same way

You missed to add your Signed-off-by tag in the whole series.

See:
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line

This can be added automatically using the "-s" option of the "git
format-patch" command, also the resend version using the "-v" option.

(https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch)

Regards,

Phil.