[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/11] util/stats64: Fix min/max comparisons
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 09/11] util/stats64: Fix min/max comparisons |
Date: |
Thu, 16 Nov 2017 12:59:24 +0100 |
From: Max Reitz <address@hidden>
stat64_min_slow() and stat64_max_slow() compare the wrong way. This
makes iotest 136 fail with clang and -m32.
Signed-off-by: Max Reitz <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
util/stats64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/stats64.c b/util/stats64.c
index 9968fcceac..389c365a9e 100644
--- a/util/stats64.c
+++ b/util/stats64.c
@@ -91,7 +91,7 @@ bool stat64_min_slow(Stat64 *s, uint64_t value)
low = atomic_read(&s->low);
orig = ((uint64_t)high << 32) | low;
- if (orig < value) {
+ if (value < orig) {
/* We have to set low before high, just like stat64_min reads
* high before low. The value may become higher temporarily, but
* stat64_get does not notice (it takes the lock) and the only ill
@@ -120,7 +120,7 @@ bool stat64_max_slow(Stat64 *s, uint64_t value)
low = atomic_read(&s->low);
orig = ((uint64_t)high << 32) | low;
- if (orig > value) {
+ if (value > orig) {
/* We have to set low before high, just like stat64_max reads
* high before low. The value may become lower temporarily, but
* stat64_get does not notice (it takes the lock) and the only ill
--
2.14.3
- [Qemu-devel] [PULL 06/11] vhost-user-scsi: add missing virtqueue_size param, (continued)
- [Qemu-devel] [PULL 06/11] vhost-user-scsi: add missing virtqueue_size param, Paolo Bonzini, 2017/11/16
- [Qemu-devel] [PULL 05/11] target-i386: adds PV_TLB_FLUSH CPUID feature bit, Paolo Bonzini, 2017/11/16
- [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Paolo Bonzini, 2017/11/16
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Peter Maydell, 2017/11/17
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Paolo Bonzini, 2017/11/17
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Peter Maydell, 2017/11/17
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/11/20
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Peter Maydell, 2017/11/20
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Peter Maydell, 2017/11/20
- Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index, Paolo Bonzini, 2017/11/20
[Qemu-devel] [PULL 09/11] util/stats64: Fix min/max comparisons,
Paolo Bonzini <=
[Qemu-devel] [PULL 08/11] cpu-exec: avoid cpu_exec_nocache infinite loop with record/replay, Paolo Bonzini, 2017/11/16
[Qemu-devel] [PULL 10/11] exec: Do not resolve subpage in mru_section, Paolo Bonzini, 2017/11/16
[Qemu-devel] [PULL 11/11] fix scripts/update-linux-headers.sh here document, Paolo Bonzini, 2017/11/16
Re: [Qemu-devel] [PULL 00/11] Miscellaneous patches for QEMU 2.11-rc2, Peter Maydell, 2017/11/16