[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 34/45] windbg: implemented kd_api_write_breakpoin
From: |
Mihail Abakumov |
Subject: |
[Qemu-devel] [PATCH v3 34/45] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint |
Date: |
Tue, 21 Nov 2017 17:10:27 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Added supporting of windbg breakpoints.
Signed-off-by: Mihail Abakumov <address@hidden>
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Signed-off-by: Dmitriy Koltunov <address@hidden>
---
include/exec/windbgstub-utils.h | 2 +
windbgstub-utils.c | 62 +++++++++++++++++++++++++++++++++++++++
windbgstub.c | 11 +++++++
3 files changed, 75 insertions(+)
diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h
index 5e5893bac8..0d9ccf9801 100755
--- a/include/exec/windbgstub-utils.h
+++ b/include/exec/windbgstub-utils.h
@@ -90,6 +90,8 @@ void kd_api_read_virtual_memory(CPUState *cpu, PacketData
*pd);
void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd);
void kd_api_get_context(CPUState *cpu, PacketData *pd);
void kd_api_set_context(CPUState *cpu, PacketData *pd);
+void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd);
+void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd);
void kd_api_read_control_space(CPUState *cpu, PacketData *pd);
void kd_api_write_control_space(CPUState *cpu, PacketData *pd);
void kd_api_unsupported(CPUState *cpu, PacketData *pd);
diff --git a/windbgstub-utils.c b/windbgstub-utils.c
index 1e81c37501..f00dab2a9d 100755
--- a/windbgstub-utils.c
+++ b/windbgstub-utils.c
@@ -14,6 +14,8 @@
static InitedAddr KPCR;
static InitedAddr version;
+static InitedAddr bps[KD_BREAKPOINT_MAX];
+
InitedAddr *windbg_get_KPCR(void)
{
return &KPCR;
@@ -71,6 +73,66 @@ void kd_api_write_virtual_memory(CPUState *cpu, PacketData
*pd)
stl_p(&mem->ActualBytesWritten, len);
}
+void kd_api_write_breakpoint(CPUState *cpu, PacketData *pd)
+{
+ DBGKD_WRITE_BREAKPOINT64 *m64c = &pd->m64.u.WriteBreakPoint;
+ target_ulong addr;
+ int i, err = 0;
+
+ addr = ldtul_p(&m64c->BreakPointAddress);
+
+ for (i = 0; i < KD_BREAKPOINT_MAX; ++i) {
+ if (!bps[i].is_init) {
+ err = cpu_breakpoint_insert(cpu, addr, BP_GDB, NULL);
+ if (!err) {
+ bps[i].addr = addr;
+ bps[i].is_init = true;
+ WINDBG_DEBUG("write_breakpoint: " FMT_ADDR, addr);
+ break;
+ } else {
+ WINDBG_ERROR("write_breakpoint: " FMT_ADDR ", " FMT_ERR,
+ addr, err);
+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;
+ return;
+ }
+ } else if (addr == bps[i].addr) {
+ break;
+ }
+ }
+
+ if (!err) {
+ stl_p(&m64c->BreakPointHandle, i + 1);
+ pd->m64.ReturnStatus = STATUS_SUCCESS;
+ } else {
+ WINDBG_ERROR("write_breakpoint: All breakpoints occupied");
+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;
+ }
+}
+
+void kd_api_restore_breakpoint(CPUState *cpu, PacketData *pd)
+{
+ DBGKD_RESTORE_BREAKPOINT *m64c = &pd->m64.u.RestoreBreakPoint;
+ uint8_t index;
+ int err = -1;
+
+ index = ldtul_p(&m64c->BreakPointHandle) - 1;
+
+ if (bps[index].is_init) {
+ err = cpu_breakpoint_remove(cpu, bps[index].addr, BP_GDB);
+ if (!err) {
+ WINDBG_DEBUG("restore_breakpoint: " FMT_ADDR ", index(%d)",
+ bps[index].addr, index);
+ } else {
+ WINDBG_ERROR("restore_breakpoint: " FMT_ADDR ", index(%d), "
+ FMT_ERR, bps[index].addr, index, err);
+ }
+ bps[index].is_init = false;
+ pd->m64.ReturnStatus = STATUS_SUCCESS;
+ } else {
+ pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;
+ }
+}
+
void kd_api_unsupported(CPUState *cpu, PacketData *pd)
{
WINDBG_ERROR("Caught unimplemented api %s",
diff --git a/windbgstub.c b/windbgstub.c
index 5b0a15ea4e..489abe6d6c 100755
--- a/windbgstub.c
+++ b/windbgstub.c
@@ -156,6 +156,14 @@ static void
windbg_process_manipulate_packet(ParsingContext *ctx)
kd_api_set_context(cpu, &ctx->data);
break;
+ case DbgKdWriteBreakPointApi:
+ kd_api_write_breakpoint(cpu, &ctx->data);
+ break;
+
+ case DbgKdRestoreBreakPointApi:
+ kd_api_restore_breakpoint(cpu, &ctx->data);
+ break;
+
case DbgKdReadControlSpaceApi:
kd_api_read_control_space(cpu, &ctx->data);
break;
@@ -164,6 +172,9 @@ static void windbg_process_manipulate_packet(ParsingContext
*ctx)
kd_api_write_control_space(cpu, &ctx->data);
break;
+ case DbgKdClearAllInternalBreakpointsApi:
+ return;
+
default:
kd_api_unsupported(cpu, &ctx->data);
break;
- [Qemu-devel] [PATCH v3 26/45] windbg: implemented windbg_read_context, (continued)
- [Qemu-devel] [PATCH v3 26/45] windbg: implemented windbg_read_context, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 25/45] windbg: implemented kd_api_read_control_space and kd_api_write_control_space, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 27/45] windbg: implemented windbg_write_context, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 28/45] windbg: implemented windbg_read_ks_regs, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 29/45] windbg: implemented windbg_write_ks_regs, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 30/45] windbg: implemented windbg_set_sr, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 31/45] windbg: implemented windbg_set_dr, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 32/45] windbg: implemented windbg_set_dr7, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 33/45] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 34/45] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint,
Mihail Abakumov <=
- [Qemu-devel] [PATCH v3 35/45] windbg: debug exception subscribing, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 36/45] windbg: implemented kd_api_continue, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 37/45] windbg: implemented kd_api_read_io_space and kd_api_write_io_space, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 38/45] windbg: implemented kd_api_read_physical_memory and kd_api_write_physical_memory, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 39/45] windbg: implemented kd_api_get_version, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 40/45] windbg: implemented kd_api_read_msr and kd_api_write_msr, Mihail Abakumov, 2017/11/21
- [Qemu-devel] [PATCH v3 41/45] windbg: implemented kd_api_search_memory, Mihail Abakumov, 2017/11/21