Re: [Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter

[Daniel P. Berrange]

On Wed, Nov 22, 2017 at 01:42:16PM +0100, Juan Quintela wrote:
> It will be used to store the uri migration parameter.  Right now it is
> just the parameter code.
> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  hmp.c                 |  7 +++++++
>  migration/migration.c | 13 +++++++++++++
>  qapi/migration.json   | 18 +++++++++++++++---
>  3 files changed, 35 insertions(+), 3 deletions(-)

> diff --git a/qapi/migration.json b/qapi/migration.json
> index bbc4671ded..ebde890604 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -488,6 +488,9 @@
>  #                     and a power of 2
>  #                     (Since 2.11)
>  #
> +# @uri: defines the method we are susing to migrate
> +#                     (Since 2.11)

On the migrate command, we've inherited the use of a URI string from the
very earliest days of QMP design, but I can't help thinking that for any
new stuff we define, we should do a full QMP model for the paraneters,
instead of continuing to use the URI. eg we should define a union of
structs, giving the individual parameters for each component, and the
tcp/unix parts probably ought to reuse the SocketAddress struct. This
is how we've approached the blockdev code in QMP, avoiding exposing the
legacy URI/filename formats in favour of full QMP modelling.

The HMP side could still continue to use a URI though.

Copying Markus/Eric for views on QMP modelling.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|