[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note()
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note() |
Date: |
Fri, 24 Nov 2017 06:20:35 +0200 |
On Thu, Nov 23, 2017 at 06:36:57AM -0800, Christoph Hellwig wrote:
> On Thu, Nov 23, 2017 at 03:02:05PM +0100, Marc-André Lureau wrote:
> > The following patch is going to use the symbol from the fw_cfg module,
> > to call the function and write the note location details in the
> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
>
> Sounds like fw_cfg should be moved to be built in only instead of
> exporting such a symbol address.
Point is, all fw cfg does is export it on to the hypervisor, so it will
have to be supported forever. If it's safe to export it to the
hypervisor then for sure it's also safe to export it to modules.
--
MST
- [Qemu-devel] [PATCH v8 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support, Marc-André Lureau, 2017/11/23
- [Qemu-devel] [PATCH v8 1/5] fw_cfg: fix driver remove, Marc-André Lureau, 2017/11/23
- [Qemu-devel] [PATCH v8 2/5] fw_cfg: add DMA register, Marc-André Lureau, 2017/11/23
- [Qemu-devel] [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note(), Marc-André Lureau, 2017/11/23
- [Qemu-devel] [PATCH v8 3/5] fw_cfg: do DMA read operation, Marc-André Lureau, 2017/11/23
- [Qemu-devel] [PATCH v8 5/5] fw_cfg: write vmcoreinfo details, Marc-André Lureau, 2017/11/23
- Re: [Qemu-devel] [PATCH v8 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support, Michael S. Tsirkin, 2017/11/28