Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

[Paolo Bonzini]

On 28/11/2017 10:03, Gonglei wrote:
> Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION
> and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side
> support crypto operation in cryptodev host-user backend.
> 
> Signed-off-by: Gonglei <address@hidden>
> Signed-off-by: Longpeng(Mike) <address@hidden>
> Signed-off-by: Zhoujian <address@hidden>
> ---
>  backends/cryptodev-vhost-user.c   | 50 +++++++++++++++++-----
>  docs/interop/vhost-user.txt       | 19 +++++++++
>  hw/virtio/vhost-user.c            | 89 
> +++++++++++++++++++++++++++++++++++++++
>  include/hw/virtio/vhost-backend.h |  8 ++++
>  4 files changed, 155 insertions(+), 11 deletions(-)

As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as
a result of sending a message on the control virtqueue.

Why can't vhost-user also process create/destroy session messages on the
control virtqueue, instead of having device-specific messages in the
protocol?

Thanks,

Paolo