Re: [Qemu-devel] [PATCH] memfd: fix configure test

[Peter Maydell]

On 28 November 2017 at 11:49, Paolo Bonzini <address@hidden> wrote:
> On 28/11/2017 12:42, Marc-André Lureau wrote:
>> It is introduced by this commit, right?
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=59d2cbb1fe4b8601d5cbd359c3806973eab6c62d
>>
>> (I added Florian Weimer in cc)
>>
>> So it's not part of glibc release yet.
>>
>> Couldn't the declarations be put in sys/memfd.h like the man claimed
>> it would be for > 1y?
>
> Yeah, that would have been better---certainly other software than QEMU
> is likely to have a static memfd_create declaration, and polluting
> sys/mman.h is going to trigger the same error.  However, at least
> systemd seems to have changed the test to sys/mman.h
> (https://github.com/systemd/systemd/pull/7468), so I think we should
> follow their lead now

I don't see why systemd should control anything. If the documentation
has been around for ages and there hasn't been a released glibc with
the incorrect placement then the implementation in glibc should follow
the documentation.

thanks
-- PMM